fix: skip empty array values in stringify#91
Merged
anonrig merged 1 commit intoanonrig:mainfrom Apr 19, 2026
Merged
Conversation
Empty array values caused malformed query strings with leading or
trailing `&` separators because the separator was appended unconditionally
for every key while the inner loop produced no output. For example,
`stringify({a: [], b: "1"})` produced `"&b=1"` and
`stringify({a: "1", b: []})` produced `"a=1&"`.
Skip empty arrays entirely and only emit the separator when the current
key actually contributes a key=value pair, matching the behavior of the
native `querystring` module.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com>
Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com>
Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 68.97% 69.31% +0.34%
==========================================
Files 7 7
Lines 448 453 +5
Branches 72 74 +2
==========================================
+ Hits 309 314 +5
Misses 136 136
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
How does node:query string behave? |
Contributor
|
@anonrig correctly. |
anonrig
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty array values caused malformed query strings with leading or trailing
&separators because the separator was appended unconditionally for every key while the inner loop produced no output. For example,stringify({a: [], b: "1"})produced"&b=1"andstringify({a: "1", b: []})produced"a=1&".Skip empty arrays entirely and only emit the separator when the current key actually contributes a key=value pair, matching the behavior of the native
querystringmodule.